-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[XLA:GPU] Rename uint32_count
to uint8_count
in GPUDriver::AsynchronousMemsetUint8
#17737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klucke
approved these changes
Sep 30, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
…iver::AsynchronousMemsetUint8` Imported from GitHub PR #17737 In `GpuDriver::AsynchronousMemsetUint8`, the count should be in bytes, instead of in uint32. Copybara import of the project: -- 17575b2 by PragmaTwice <[email protected]>: [XLA:GPU] Rename uint32_count to uint8_count in GPUDriver::AsynchronousMemsetUint8 Merging this change closes #17737 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17737 from PragmaTwice:fix-typo 17575b2 PiperOrigin-RevId: 680607857
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 30, 2024
…iver::AsynchronousMemsetUint8` Imported from GitHub PR openxla/xla#17737 In `GpuDriver::AsynchronousMemsetUint8`, the count should be in bytes, instead of in uint32. Copybara import of the project: -- 17575b22ef2fa43d9409c2b29ea408e3fc958155 by PragmaTwice <[email protected]>: [XLA:GPU] Rename uint32_count to uint8_count in GPUDriver::AsynchronousMemsetUint8 Merging this change closes #17737 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17737 from PragmaTwice:fix-typo 17575b22ef2fa43d9409c2b29ea408e3fc958155 PiperOrigin-RevId: 680607857
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
…iver::AsynchronousMemsetUint8` Imported from GitHub PR #17737 In `GpuDriver::AsynchronousMemsetUint8`, the count should be in bytes, instead of in uint32. Copybara import of the project: -- 17575b2 by PragmaTwice <[email protected]>: [XLA:GPU] Rename uint32_count to uint8_count in GPUDriver::AsynchronousMemsetUint8 Merging this change closes #17737 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17737 from PragmaTwice:fix-typo 17575b2 PiperOrigin-RevId: 680607857
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 30, 2024
…iver::AsynchronousMemsetUint8` Imported from GitHub PR openxla/xla#17737 In `GpuDriver::AsynchronousMemsetUint8`, the count should be in bytes, instead of in uint32. Copybara import of the project: -- 17575b22ef2fa43d9409c2b29ea408e3fc958155 by PragmaTwice <[email protected]>: [XLA:GPU] Rename uint32_count to uint8_count in GPUDriver::AsynchronousMemsetUint8 Merging this change closes #17737 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17737 from PragmaTwice:fix-typo 17575b22ef2fa43d9409c2b29ea408e3fc958155 PiperOrigin-RevId: 680607857
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 30, 2024
…M will codegen. The flag doesn't do anything in this PR. Implementation is in a separate PR (#17722). FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17737 from PragmaTwice:fix-typo 17575b22ef2fa43d9409c2b29ea408e3fc958155 PiperOrigin-RevId: 680591092
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 30, 2024
…iver::AsynchronousMemsetUint8` Imported from GitHub PR openxla/xla#17737 In `GpuDriver::AsynchronousMemsetUint8`, the count should be in bytes, instead of in uint32. Copybara import of the project: -- 17575b22ef2fa43d9409c2b29ea408e3fc958155 by PragmaTwice <[email protected]>: [XLA:GPU] Rename uint32_count to uint8_count in GPUDriver::AsynchronousMemsetUint8 Merging this change closes #17737 PiperOrigin-RevId: 680656988
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Sep 30, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17737 from PragmaTwice:fix-typo 17575b22ef2fa43d9409c2b29ea408e3fc958155 PiperOrigin-RevId: 680661498
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
GpuDriver::AsynchronousMemsetUint8
, the count should be in bytes, instead of in uint32.